diff options
| author | Zach Reizner <zachr@google.com> | 2017-09-04 14:52:16 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-09-06 14:31:06 -0700 |
| commit | 35d4950c3f7c7fe87dc01397c0210e32b11cece0 (patch) | |
| tree | c4930f1c11c55a58307683884e9dba83fa1d1e2e /src/main.rs | |
| parent | efe957849b5d645b115f677701ad779d42ef7574 (diff) | |
| download | crosvm-35d4950c3f7c7fe87dc01397c0210e32b11cece0.tar crosvm-35d4950c3f7c7fe87dc01397c0210e32b11cece0.tar.gz crosvm-35d4950c3f7c7fe87dc01397c0210e32b11cece0.tar.bz2 crosvm-35d4950c3f7c7fe87dc01397c0210e32b11cece0.tar.lz crosvm-35d4950c3f7c7fe87dc01397c0210e32b11cece0.tar.xz crosvm-35d4950c3f7c7fe87dc01397c0210e32b11cece0.tar.zst crosvm-35d4950c3f7c7fe87dc01397c0210e32b11cece0.zip | |
io_jail: implement Display for Error
Running crosvm in multiprocess mode includes setting up an io_jail for each device and it can very often fail due to problems in the enviroment, such as missing policy files or lack of privilege. The auto generated debug error messages were not very good (based on initial user feedback) and so this CL implements display to help make the errors more understandable when they are printed. BUG=None TEST=./build_test Change-Id: If51c00e60abb9b0d482515fa1e401f2fa6fb9e8f Reviewed-on: https://chromium-review.googlesource.com/649950 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org>
Diffstat (limited to 'src/main.rs')
| -rw-r--r-- | src/main.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main.rs b/src/main.rs index 85d39a5..ee808c9 100644 --- a/src/main.rs +++ b/src/main.rs @@ -112,8 +112,8 @@ impl fmt::Display for Error { &Error::NetDeviceRootSetup(ref e) => { write!(f, "failed to create root directory for a net device: {:?}", e) } - &Error::DeviceJail(ref e) => write!(f, "failed to jail device: {:?}", e), - &Error::DevicePivotRoot(ref e) => write!(f, "failed to pivot root device: {:?}", e), + &Error::DeviceJail(ref e) => write!(f, "failed to jail device: {}", e), + &Error::DevicePivotRoot(ref e) => write!(f, "failed to pivot root device: {}", e), &Error::RegisterNet(ref e) => write!(f, "error registering net device: {:?}", e), &Error::RegisterRng(ref e) => write!(f, "error registering rng device: {:?}", e), &Error::RngDeviceNew(ref e) => write!(f, "failed to set up rng: {:?}", e), |