diff options
author | Zach Reizner <zachr@google.com> | 2019-09-10 16:11:18 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-09-11 09:34:12 +0000 |
commit | 506105dc0dcfbbdec907f672e8d782b2f8604447 (patch) | |
tree | de31f815541f9195f537bc8142832b68f766762c /qcow | |
parent | 532533dd3994ef2047dea770e799831b4c38418e (diff) | |
download | crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.gz crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.bz2 crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.lz crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.xz crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.zst crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.zip |
use `SharedMemory::{named, anon}` to replace `::new`
The new constructors are shorter and omit the bare `None` in the `anon` call sites which gave no clues to the reader what the effect of that `None` was. This should improve readability. TEST=./build_test BUG=None Change-Id: I2e34e7df9a4ccc5da50edf4e963a6a42e3d84b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1797188 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>
Diffstat (limited to 'qcow')
-rw-r--r-- | qcow/src/qcow.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/qcow/src/qcow.rs b/qcow/src/qcow.rs index 3153df1..aaff5f1 100644 --- a/qcow/src/qcow.rs +++ b/qcow/src/qcow.rs @@ -1646,7 +1646,7 @@ mod tests { where F: FnMut(File), { - let shm = SharedMemory::new(None).unwrap(); + let shm = SharedMemory::anon().unwrap(); let mut disk_file: File = shm.into(); disk_file.write_all(&header).unwrap(); disk_file.set_len(0x1_0000_0000).unwrap(); @@ -1659,7 +1659,7 @@ mod tests { where F: FnMut(QcowFile), { - let shm = SharedMemory::new(None).unwrap(); + let shm = SharedMemory::anon().unwrap(); let qcow_file = QcowFile::new(shm.into(), file_size).unwrap(); testfn(qcow_file); // File closed when the function exits. @@ -1668,7 +1668,7 @@ mod tests { #[test] fn default_header() { let header = QcowHeader::create_for_size(0x10_0000); - let shm = SharedMemory::new(None).unwrap(); + let shm = SharedMemory::anon().unwrap(); let mut disk_file: File = shm.into(); header .write_to(&mut disk_file) |