diff options
author | Matt Delco <delco@chromium.org> | 2019-10-10 14:13:23 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-10-23 22:20:19 +0000 |
commit | 193d68404643c55558dba5145453666a4adbd2e8 (patch) | |
tree | 66c48ce469ec4876188eb9f7702c9498fc099c65 /net_sys | |
parent | 4ad168c0d7859fd8bcefe77b60c14327f094f6e7 (diff) | |
download | crosvm-193d68404643c55558dba5145453666a4adbd2e8.tar crosvm-193d68404643c55558dba5145453666a4adbd2e8.tar.gz crosvm-193d68404643c55558dba5145453666a4adbd2e8.tar.bz2 crosvm-193d68404643c55558dba5145453666a4adbd2e8.tar.lz crosvm-193d68404643c55558dba5145453666a4adbd2e8.tar.xz crosvm-193d68404643c55558dba5145453666a4adbd2e8.tar.zst crosvm-193d68404643c55558dba5145453666a4adbd2e8.zip |
plugin: only pause on EINTR
In the case of 1) an IO exit & callout to plugin, then 2) a pause request by another thread, the vcpu thread will eagerly check for a pause request and might cause another callout to the plugin for the pause. We haven't yet run KVM again for it to emulate the completion of the IO. It's probably less risky to call back into KVM again and let it finish the emulation before we callout to the plugin to make other potential state changes to the VM. This change also reduces the overhead of the non-pause case by not checking for a pause request on each VM exit. The tradeoff is that a pause request might take longer, but these are (or should be) relatively rare so it's better to slow these down (and be more conserative/sane about the state of the VM when pause is reported) in favor of making the non-pause VM exits faster. BUG=None TEST=Local build and run of "build_test". Change-Id: I38609eccd9a2196835f99de5ea84a586928fab30 Signed-off-by: Matt Delco <delco@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1863725 Reviewed-by: Zach Reizner <zachr@chromium.org>
Diffstat (limited to 'net_sys')
0 files changed, 0 insertions, 0 deletions