lint: Resolve the easier clippy lints

Hopefully the changes are self-explanatory and uncontroversial. This
eliminates much of the noise from `cargo clippy` and, for my purposes,
gives me a reasonable way to use it as a tool when writing and reviewing
code.

Here is the Clippy invocation I was using:

    cargo +nightly clippy -- -W clippy::correctness -A renamed_and_removed_lints -Aclippy::{blacklisted_name,borrowed_box,cast_lossless,cast_ptr_alignment,enum_variant_names,identity_op,if_same_then_else,mut_from_ref,needless_pass_by_value,new_without_default,new_without_default_derive,or_fun_call,ptr_arg,should_implement_trait,single_match,too_many_arguments,trivially_copy_pass_by_ref,unreadable_literal,unsafe_vector_initialization,useless_transmute}

TEST=cargo check --features wl-dmabuf,gpu,usb-emulation
TEST=boot linux

Change-Id: I55eb1b4a72beb2f762480e3333a921909314a0a2
Reviewed-on: https://chromium-review.googlesource.com/1356911
Commit-Ready: David Tolnay <dtolnay@chromium.org>
Tested-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

1 files changed, 14 insertions, 13 deletions

diff --git a/kernel_loader/src/lib.rs b/kernel_loader/src/lib.rs
index 23405d9..42b43de 100644
--- a/kernel_loader/src/lib.rs
+++ b/kernel_loader/src/lib.rs
@@ -16,6 +16,7 @@ use sys_util::{GuestAddress, GuestMemory};
 #[allow(non_camel_case_types)]
 #[allow(non_snake_case)]
 #[allow(non_upper_case_globals)]
+#[cfg_attr(feature = "cargo-clippy", allow(clippy))]
 mod elf;
 
 #[derive(Debug, PartialEq)]
@@ -39,21 +40,21 @@ pub type Result<T> = std::result::Result<T, Error>;
 impl error::Error for Error {
     fn description(&self) -> &str {
         match self {
-            &Error::BigEndianElfOnLittle => {
+            Error::BigEndianElfOnLittle => {
                 "Trying to load big-endian binary on little-endian machine"
             }
-            &Error::CommandLineCopy => "Failed writing command line to guest memory",
-            &Error::CommandLineOverflow => "Command line overflowed guest memory",
-            &Error::InvalidElfMagicNumber => "Invalid Elf magic number",
-            &Error::InvalidProgramHeaderSize => "Invalid program header size",
-            &Error::InvalidProgramHeaderOffset => "Invalid program header offset",
-            &Error::InvalidProgramHeaderAddress => "Invalid Program Header Address",
-            &Error::ReadElfHeader => "Unable to read elf header",
-            &Error::ReadKernelImage => "Unable to read kernel image",
-            &Error::ReadProgramHeader => "Unable to read program header",
-            &Error::SeekKernelStart => "Unable to seek to kernel start",
-            &Error::SeekElfStart => "Unable to seek to elf start",
-            &Error::SeekProgramHeader => "Unable to seek to program header",
+            Error::CommandLineCopy => "Failed writing command line to guest memory",
+            Error::CommandLineOverflow => "Command line overflowed guest memory",
+            Error::InvalidElfMagicNumber => "Invalid Elf magic number",
+            Error::InvalidProgramHeaderSize => "Invalid program header size",
+            Error::InvalidProgramHeaderOffset => "Invalid program header offset",
+            Error::InvalidProgramHeaderAddress => "Invalid Program Header Address",
+            Error::ReadElfHeader => "Unable to read elf header",
+            Error::ReadKernelImage => "Unable to read kernel image",
+            Error::ReadProgramHeader => "Unable to read program header",
+            Error::SeekKernelStart => "Unable to seek to kernel start",
+            Error::SeekElfStart => "Unable to seek to elf start",
+            Error::SeekProgramHeader => "Unable to seek to program header",
         }
     }
 }