diff options
author | Dylan Reid <dgreid@chromium.org> | 2017-05-22 18:38:56 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2017-06-30 22:24:49 -0700 |
commit | 222f7328216625caa783a1666c6cbbd0a80b9c99 (patch) | |
tree | 6ecc690f4a1fdb8a26ce7b6c4ee2f9590b1d65a9 /kernel_loader | |
parent | db8a35a1b11e5f7ca93399a5ccea8f0fe7aacea9 (diff) | |
download | crosvm-222f7328216625caa783a1666c6cbbd0a80b9c99.tar crosvm-222f7328216625caa783a1666c6cbbd0a80b9c99.tar.gz crosvm-222f7328216625caa783a1666c6cbbd0a80b9c99.tar.bz2 crosvm-222f7328216625caa783a1666c6cbbd0a80b9c99.tar.lz crosvm-222f7328216625caa783a1666c6cbbd0a80b9c99.tar.xz crosvm-222f7328216625caa783a1666c6cbbd0a80b9c99.tar.zst crosvm-222f7328216625caa783a1666c6cbbd0a80b9c99.zip |
kernel_loader: Fix clippy warnings.
Should use &<vec> instead of <vec>.iter() in a for loop. cmdline returns a size that can't be negative. Change-Id: I5f0ee3584d8890ac26feaadb99360b2d23f67d70 Signed-off-by: Dylan Reid <dgreid@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/515604 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>
Diffstat (limited to 'kernel_loader')
-rw-r--r-- | kernel_loader/src/lib.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel_loader/src/lib.rs b/kernel_loader/src/lib.rs index 89b6348..3be9889 100644 --- a/kernel_loader/src/lib.rs +++ b/kernel_loader/src/lib.rs @@ -79,7 +79,7 @@ pub fn load_kernel<F>(guest_mem: &GuestMemory, kernel_start: GuestAddress, kerne }; // Read in each section pointed to by the program headers. - for phdr in phdrs.iter() { + for phdr in &phdrs { if (phdr.p_type & elf::PT_LOAD) == 0 || phdr.p_filesz == 0 { continue; } @@ -105,7 +105,7 @@ pub fn load_kernel<F>(guest_mem: &GuestMemory, kernel_start: GuestAddress, kerne /// * `cmdline` - The kernel command line. pub fn load_cmdline(guest_mem: &GuestMemory, guest_addr: GuestAddress, cmdline: &CStr) -> Result<()> { let len = cmdline.to_bytes().len(); - if len <= 0 { + if len == 0 { return Ok(()); } |