summary refs log tree commit diff
path: root/devices
diff options
context:
space:
mode:
authorDaniel Verkamp <dverkamp@chromium.org>2019-11-01 15:25:40 -0700
committerCommit Bot <commit-bot@chromium.org>2019-11-18 07:43:05 +0000
commit2a9e620f9a8330ab63f6445556a82b17e783f0e4 (patch)
tree089d56c4f5dd02cdb15c5fd739859a4af16d38ca /devices
parent5eca9379410b0d2422d540dded995523edf6fdc9 (diff)
downloadcrosvm-2a9e620f9a8330ab63f6445556a82b17e783f0e4.tar
crosvm-2a9e620f9a8330ab63f6445556a82b17e783f0e4.tar.gz
crosvm-2a9e620f9a8330ab63f6445556a82b17e783f0e4.tar.bz2
crosvm-2a9e620f9a8330ab63f6445556a82b17e783f0e4.tar.lz
crosvm-2a9e620f9a8330ab63f6445556a82b17e783f0e4.tar.xz
crosvm-2a9e620f9a8330ab63f6445556a82b17e783f0e4.tar.zst
crosvm-2a9e620f9a8330ab63f6445556a82b17e783f0e4.zip
devices: virtio: remove unused VirtioPciDevice functions
The queue_evts() and interrupt_evt() functions were public, but nothing
was calling them.  Remove them to clean up the unused code.

BUG=None
TEST=./build_test

Change-Id: Id36e78343869746c733bba04383ab93c9d377601
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1898270
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Diffstat (limited to 'devices')
-rw-r--r--devices/src/virtio/virtio_pci_device.rs14
1 files changed, 1 insertions, 13 deletions
diff --git a/devices/src/virtio/virtio_pci_device.rs b/devices/src/virtio/virtio_pci_device.rs
index b79a98a..d31821e 100644
--- a/devices/src/virtio/virtio_pci_device.rs
+++ b/devices/src/virtio/virtio_pci_device.rs
@@ -238,18 +238,6 @@ impl VirtioPciDevice {
         })
     }
 
-    /// Gets the list of queue events that must be triggered whenever the VM writes to
-    /// `virtio::NOTIFY_REG_OFFSET` past the MMIO base. Each event must be triggered when the
-    /// value being written equals the index of the event in this list.
-    pub fn queue_evts(&self) -> &[EventFd] {
-        self.queue_evts.as_slice()
-    }
-
-    /// Gets the event this device uses to interrupt the VM when the used queue is changed.
-    pub fn interrupt_evt(&self) -> Option<&EventFd> {
-        self.interrupt_evt.as_ref()
-    }
-
     fn is_driver_ready(&self) -> bool {
         let ready_bits =
             (DEVICE_ACKNOWLEDGE | DEVICE_DRIVER | DEVICE_DRIVER_OK | DEVICE_FEATURES_OK) as u8;
@@ -460,7 +448,7 @@ impl PciDevice for VirtioPciDevice {
     fn ioeventfds(&self) -> Vec<(&EventFd, u64, Datamatch)> {
         let bar0 = self.config_regs.get_bar_addr(self.settings_bar as usize);
         let notify_base = bar0 + NOTIFICATION_BAR_OFFSET;
-        self.queue_evts()
+        self.queue_evts
             .iter()
             .enumerate()
             .map(|(i, event)| {