summary refs log tree commit diff
path: root/devices/src
diff options
context:
space:
mode:
authorZach Reizner <zachr@google.com>2018-03-06 21:41:15 -0800
committerchrome-bot <chrome-bot@chromium.org>2018-03-07 19:47:11 -0800
commitd1ab49367236397bcbb3fc7b5bc0077c6a761273 (patch)
treee4b0bdd1f68189a9e3e2a5b15ccaf6093cebcdbf /devices/src
parentab4994a64621c596fab8944f5c59b356489250db (diff)
downloadcrosvm-d1ab49367236397bcbb3fc7b5bc0077c6a761273.tar
crosvm-d1ab49367236397bcbb3fc7b5bc0077c6a761273.tar.gz
crosvm-d1ab49367236397bcbb3fc7b5bc0077c6a761273.tar.bz2
crosvm-d1ab49367236397bcbb3fc7b5bc0077c6a761273.tar.lz
crosvm-d1ab49367236397bcbb3fc7b5bc0077c6a761273.tar.xz
crosvm-d1ab49367236397bcbb3fc7b5bc0077c6a761273.tar.zst
crosvm-d1ab49367236397bcbb3fc7b5bc0077c6a761273.zip
fix some clippy errors that are default deny
Clippy only has 6 lints that are defaulted to deny, which this CL fixes.
The first step to running clippy and establishing our own set of default
deny lints, is to ensure we aren't running afoul of the most common
deny lints.

BUG=None
TEST=cargo clippy --all

Change-Id: I225801357d76a8a9e246e3842bc9bf550fcd7207
Reviewed-on: https://chromium-review.googlesource.com/952045
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Diffstat (limited to 'devices/src')
-rw-r--r--devices/src/virtio/balloon.rs2
-rw-r--r--devices/src/virtio/block.rs2
2 files changed, 2 insertions, 2 deletions
diff --git a/devices/src/virtio/balloon.rs b/devices/src/virtio/balloon.rs
index 5cfdbcf..96386d7 100644
--- a/devices/src/virtio/balloon.rs
+++ b/devices/src/virtio/balloon.rs
@@ -257,7 +257,7 @@ impl VirtioDevice for Balloon {
             .unwrap();
         if let Some(end) = offset.checked_add(data.len() as u64) {
             // This write can't fail, offset and end are checked against the length of config.
-            data.write(&config[offset as usize..cmp::min(end, 8) as usize])
+            data.write_all(&config[offset as usize..cmp::min(end, 8) as usize])
                 .unwrap();
         }
     }
diff --git a/devices/src/virtio/block.rs b/devices/src/virtio/block.rs
index c4f6299..ca0b222 100644
--- a/devices/src/virtio/block.rs
+++ b/devices/src/virtio/block.rs
@@ -340,7 +340,7 @@ impl<T: 'static + AsRawFd + DiskFile + Send> VirtioDevice for Block<T> {
         }
         if let Some(end) = offset.checked_add(data.len() as u64) {
             // This write can't fail, offset and end are checked against config_len.
-            data.write(&self.config_space[offset as usize..cmp::min(end, config_len) as usize])
+            data.write_all(&self.config_space[offset as usize..cmp::min(end, config_len) as usize])
                 .unwrap();
         }
     }