devices: vfio: fix clippy warnings

Fix boxed_local, const_static_lifetime, useless_format, and
redundant_closure clippy warnings in the VFIO code.

This fixes all clippy warnings except a single instance of
let_and_return in VfioPciDevice::keep_fds(), since that code is modified
in an upcoming patch.

BUG=None
TEST=./build_test.py
TEST=bin/clippy

Change-Id: I548adbc6b92448fc0db82ed72214d73b0eabaf5c
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1822697
Reviewed-by: Xiong  Zhang <xiong.y.zhang@intel.corp-partner.google.com>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Tested-by: Xiong  Zhang <xiong.y.zhang@intel.corp-partner.google.com>
Tested-by: kokoro <noreply+kokoro@google.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/devices/src/pci/vfio_pci.rs b/devices/src/pci/vfio_pci.rs
index 9073312..5b0474a 100644
--- a/devices/src/pci/vfio_pci.rs
+++ b/devices/src/pci/vfio_pci.rs
@@ -100,8 +100,8 @@ pub struct VfioPciDevice {
 
 impl VfioPciDevice {
     /// Constructs a new Vfio Pci device for the give Vfio device
-    pub fn new(device: Box<VfioDevice>) -> Self {
-        let dev = Arc::new(*device);
+    pub fn new(device: VfioDevice) -> Self {
+        let dev = Arc::new(device);
         let config = VfioPciConfig::new(Arc::clone(&dev));
         VfioPciDevice {
             device: dev,
@@ -131,7 +131,7 @@ impl VfioPciDevice {
 
 impl PciDevice for VfioPciDevice {
     fn debug_label(&self) -> String {
-        format!("vfio pci device")
+        "vfio pci device".to_string()
     }
 
     fn assign_bus_dev(&mut self, bus: u8, device: u8) {