diff options
author | David Tolnay <dtolnay@chromium.org> | 2019-04-15 16:58:42 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-18 19:51:01 -0700 |
commit | dc4effa72b214bc3bd14ca2f7772ab1b728aef5b (patch) | |
tree | 61c308a8c165a6fbe65f947da4abd241a9dd265d /crosvm_plugin | |
parent | 64cd5eae5778b86f6e498a6fa1b1962693aa5a46 (diff) | |
download | crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.gz crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.bz2 crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.lz crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.xz crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.tar.zst crosvm-dc4effa72b214bc3bd14ca2f7772ab1b728aef5b.zip |
clippy: Iterate without calling .iter()
See: https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop https://rust-lang.github.io/rust-clippy/master/index.html#explicit_into_iter_loop Before: for element in slice.iter() {...} After: for element in slice {...} TEST=grep -r '\.iter() {' TEST=grep -r '\.iter_mut() {' TEST=grep -r '\.into_iter() {' TEST=cargo check --all-features TEST=local kokoro Change-Id: I27f0df7cfa1064b2c8b162cba263513926a433a9 Reviewed-on: https://chromium-review.googlesource.com/1568525 Commit-Ready: David Tolnay <dtolnay@chromium.org> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Diffstat (limited to 'crosvm_plugin')
-rw-r--r-- | crosvm_plugin/src/lib.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crosvm_plugin/src/lib.rs b/crosvm_plugin/src/lib.rs index 31684b3..eb2cf21 100644 --- a/crosvm_plugin/src/lib.rs +++ b/crosvm_plugin/src/lib.rs @@ -1049,7 +1049,7 @@ impl crosvm_vcpu { if *msr_count > msr_entries.len() { return Err(E2BIG); } - for (&msr_data, msr_entry) in get_msrs.get_entry_data().iter().zip(msr_entries.iter_mut()) { + for (&msr_data, msr_entry) in get_msrs.get_entry_data().iter().zip(msr_entries) { msr_entry.data = msr_data; } Ok(()) @@ -1059,7 +1059,7 @@ impl crosvm_vcpu { let mut r = VcpuRequest::new(); let set_msrs_entries: &mut RepeatedField<VcpuRequest_MsrEntry> = r.mut_set_msrs().mut_entries(); - for msr_entry in msr_entries.iter() { + for msr_entry in msr_entries { let mut entry = VcpuRequest_MsrEntry::new(); entry.index = msr_entry.index; entry.data = msr_entry.data; @@ -1073,7 +1073,7 @@ impl crosvm_vcpu { fn set_cpuid(&mut self, cpuid_entries: &[kvm_cpuid_entry2]) -> result::Result<(), c_int> { let mut r = VcpuRequest::new(); let set_cpuid_entries: &mut RepeatedField<CpuidEntry> = r.mut_set_cpuid().mut_entries(); - for cpuid_entry in cpuid_entries.iter() { + for cpuid_entry in cpuid_entries { set_cpuid_entries.push(cpuid_kvm_to_proto(cpuid_entry)); } |