diff options
| author | David Tolnay <dtolnay@chromium.org> | 2019-04-12 16:57:48 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-18 19:51:29 -0700 |
| commit | 4b292afafcd44ca3fc34f483a8edb455a3212cb5 (patch) | |
| tree | 868bdb3122e088e33836cd48608d23518ee5a1d0 /bin | |
| parent | dc4effa72b214bc3bd14ca2f7772ab1b728aef5b (diff) | |
| download | crosvm-4b292afafcd44ca3fc34f483a8edb455a3212cb5.tar crosvm-4b292afafcd44ca3fc34f483a8edb455a3212cb5.tar.gz crosvm-4b292afafcd44ca3fc34f483a8edb455a3212cb5.tar.bz2 crosvm-4b292afafcd44ca3fc34f483a8edb455a3212cb5.tar.lz crosvm-4b292afafcd44ca3fc34f483a8edb455a3212cb5.tar.xz crosvm-4b292afafcd44ca3fc34f483a8edb455a3212cb5.tar.zst crosvm-4b292afafcd44ca3fc34f483a8edb455a3212cb5.zip | |
clippy: Resolve cast_ptr_alignment
This CL fixes four cases of what I believe are undefined behavior:
- In vhost where the original code allocates a Vec<u8> with 1-byte
alignment and casts the Vec's data pointer to a &mut vhost_memory
which is required to be 8-byte aligned. Underaligned references of
type &T or &mut T are always undefined behavior in Rust.
- Same pattern in x86_64.
- Same pattern in plugin::vcpu.
- Code in crosvm_plugin that dereferences a potentially underaligned
pointer. This is always undefined behavior in Rust.
TEST=bin/clippy
TEST=cargo test sys_util
Change-Id: I926f17b1fe022a798f69d738f9990d548f40c59b
Reviewed-on: https://chromium-review.googlesource.com/1566736
Commit-Ready: David Tolnay <dtolnay@chromium.org>
Tested-by: David Tolnay <dtolnay@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Diffstat (limited to 'bin')
| -rwxr-xr-x | bin/clippy | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/bin/clippy b/bin/clippy index 0ffb049..a19b6eb 100755 --- a/bin/clippy +++ b/bin/clippy @@ -18,9 +18,6 @@ SUPPRESS=( range_plus_one unit_arg - # To be resolved or suppressed locally. - cast_ptr_alignment - # We don't care about these lints. Okay to remain suppressed globally. blacklisted_name cast_lossless |